Skip to content

fixes EmbeddingScorer._prepare() passes arg of wrong type #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anthonyduong9
Copy link
Contributor

Fixes #132

@anthonyduong9 anthonyduong9 marked this pull request as draft June 5, 2025 00:24
@anthonyduong9 anthonyduong9 force-pushed the fix-EmbeddingScorer_prepare-passes-arg-of-wrong-type branch from c26a66e to 965a3cc Compare June 10, 2025 23:34
@anthonyduong9 anthonyduong9 marked this pull request as ready for review June 11, 2025 00:35
@SrGonao
Copy link
Collaborator

SrGonao commented Jun 12, 2025

I ended up making this PR in a very ugly way, adding a bunch of things that should be done elsewhere, but such is life

@SrGonao SrGonao merged commit 66fa7c4 into EleutherAI:main Jun 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EmbeddingScorer._prepare() passes arg of wrong type to examples_to_samples()
2 participants